I've been doing a lot of work with SSIS (SQL Server Integration Services - the new DTS) recently and I'm really dissappointed with the adherence to Microsoft's own standards in their API. Take this little piece of code from a custom component and see how many violations you can spot?

if (!ValidateOutputColumns(output.ID))
{
    ComponentMetaData.FireError(
        0,
        "Validate",
        "Output columns and/or meta data are out of sync",
        "",
        0,
        out pbCancel);
    
    return DTSValidationStatus.VS_NEEDSNEWMETADATA;
}

(Note, I've deliberately done something a little odd to highlight one of the violations).

Surely everybody at MS has to use FxCop, which would have picked up all of these?